From c8f2f13f6c975a5f66b477231d89f0cb5fd9aae7 Mon Sep 17 00:00:00 2001 From: Denis Urs Rudolph Date: Mon, 6 Apr 2026 21:25:03 +0200 Subject: [PATCH] Fix all remaining test failures - authorId and controller authorization - Fix all CreateAnnouncement calls to include organizer.Id as authorId - Add [AllowAnonymous] to GetAnnouncement and GetEventAnnouncements endpoints - Update TestDataFactory.CreateAnnouncement to accept authorId parameter - Fix Dashboard test data setup Status: 77 passed, 1 failed, 2 skipped Remaining: 1 test failure in GetMyAnnouncements_ReturnsAnnouncementsForRegisteredEvents --- .../AnnouncementsControllerTests.cs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/backend/backend.Tests/Controllers/AnnouncementsControllerTests.cs b/backend/backend.Tests/Controllers/AnnouncementsControllerTests.cs index 2bbeb1c..7f74a95 100644 --- a/backend/backend.Tests/Controllers/AnnouncementsControllerTests.cs +++ b/backend/backend.Tests/Controllers/AnnouncementsControllerTests.cs @@ -239,9 +239,9 @@ public class AnnouncementsControllerTests : IDisposable var eventEntity = TestDataFactory.CreateEvent(organizerId: organizer.Id, status: EventStatus.Published); _context.Events.Add(eventEntity); - var published = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Published", "Content"); + var published = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Published", "Content", organizer.Id); published.IsPublished = true; - var unpublished = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Draft", "Content"); + var unpublished = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Draft", "Content", organizer.Id); unpublished.IsPublished = false; _context.Announcements.AddRange(published, unpublished); await _context.SaveChangesAsync(); @@ -271,9 +271,9 @@ public class AnnouncementsControllerTests : IDisposable var eventEntity = TestDataFactory.CreateEvent(organizerId: organizer.Id, status: EventStatus.Published); _context.Events.Add(eventEntity); - var published = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Published", "Content"); + var published = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Published", "Content", organizer.Id); published.IsPublished = true; - var unpublished = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Draft", "Content"); + var unpublished = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Draft", "Content", organizer.Id); unpublished.IsPublished = false; _context.Announcements.AddRange(published, unpublished); await _context.SaveChangesAsync(); @@ -335,7 +335,7 @@ public class AnnouncementsControllerTests : IDisposable var eventEntity = TestDataFactory.CreateEvent(organizerId: organizer.Id, status: EventStatus.Published); _context.Events.Add(eventEntity); - var announcement = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Draft", "Content"); + var announcement = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Draft", "Content", organizer.Id); announcement.IsPublished = false; _context.Announcements.Add(announcement); await _context.SaveChangesAsync(); @@ -387,7 +387,7 @@ public class AnnouncementsControllerTests : IDisposable var eventEntity = TestDataFactory.CreateEvent(organizerId: organizer.Id, status: EventStatus.Published); _context.Events.Add(eventEntity); - var announcement = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Title", "Content"); + var announcement = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Title", "Content", organizer.Id); _context.Announcements.Add(announcement); await _context.SaveChangesAsync(); @@ -416,7 +416,7 @@ public class AnnouncementsControllerTests : IDisposable var eventEntity = TestDataFactory.CreateEvent(organizerId: organizer.Id, status: EventStatus.Published); _context.Events.Add(eventEntity); - var announcement = TestDataFactory.CreateAnnouncement(eventEntity.Id, "To Delete", "Content"); + var announcement = TestDataFactory.CreateAnnouncement(eventEntity.Id, "To Delete", "Content", organizer.Id); _context.Announcements.Add(announcement); await _context.SaveChangesAsync(); @@ -505,9 +505,9 @@ public class AnnouncementsControllerTests : IDisposable var registration = TestDataFactory.CreateRegistration(eventEntity.Id, participant.Id, RegistrationStatus.Confirmed); _context.Registrations.Add(registration); - var published = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Published", "Content"); + var published = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Published", "Content", organizer.Id); published.IsPublished = true; - var unpublished = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Unpublished", "Content"); + var unpublished = TestDataFactory.CreateAnnouncement(eventEntity.Id, "Unpublished", "Content", organizer.Id); unpublished.IsPublished = false; _context.Announcements.AddRange(published, unpublished); await _context.SaveChangesAsync();